Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to v1.4.0-beta.1 & implement key-only Iteration #450

Merged
merged 11 commits into from
Aug 30, 2023
Merged

Upgrade to v1.4.0-beta.1 & implement key-only Iteration #450

merged 11 commits into from
Aug 30, 2023

Conversation

chipshort
Copy link
Collaborator

@chipshort chipshort commented Aug 25, 2023 •
edited
Loading

closes CosmWasm/cosmwasm#1498

Draft because CosmWasm/cosmwasm#1834 is not merged released yet (so I am using a dependency on the commit)

webmaster128
webmaster128 reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

internal/api/callbacks.go Show resolved Hide resolved
internal/api/lib_test.go Outdated Show resolved Hide resolved
libwasmvm/bindings.h Outdated Show resolved Hide resolved
libwasmvm/src/iterator.rs Outdated Show resolved Hide resolved
libwasmvm/src/iterator.rs Outdated Show resolved Hide resolved
libwasmvm/src/storage.rs Show resolved Hide resolved
@webmaster128 webmaster128 mentioned this pull request Aug 28, 2023
Merged
webmaster128
webmaster128 reviewed Aug 28, 2023
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@chipshort chipshort mentioned this pull request Aug 28, 2023
Merged
webmaster128
webmaster128 reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 🎖️ This not only avoids copying the values around but never reads them from database.

libwasmvm/src/iterator.rs Outdated Show resolved Hide resolved
internal/api/callbacks.go Outdated Show resolved Hide resolved
@webmaster128
Copy link
Member

Is this ready? Looks good as far as I can tell

@chipshort chipshort marked this pull request as ready for review August 30, 2023 07:27
@chipshort
Copy link
Collaborator Author

Yes, this is ready now (if we are fine with the 1.4.0-beta dependency)

@webmaster128 webmaster128 changed the title Key-only Iteration Upgrade to v1.4.0-beta.1 & implement key-only Iteration Aug 30, 2023
@webmaster128 webmaster128 added this to the 1.4.0 milestone Aug 30, 2023
webmaster128
webmaster128 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@webmaster128 webmaster128 merged commit c34e346 into main Aug 30, 2023
2 checks passed
@webmaster128 webmaster128 deleted the 1498-key-only-iteration branch August 30, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Key-only iteration
2 participants
@chipshort @webmaster128